Skip to content

Conversation

@enmande
Copy link
Contributor

@enmande enmande commented Jan 8, 2026

๐ŸŽŸ๏ธ Tracking

PM-30609

๐Ÿ“” Objective

Add Redis to the cloud docker-compose profile. This makes Redis by default required for cloud development.

docker compose --profile cloud up [-d] will now start the Redis backplane by default.

A connection string for globalSettings.distributedCache.redis.connectionString will be required for consumption. See tracking ticket for coordinated updates.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ add70b5b-ef8a-4971-9f81-de1afec5029f

Fixed Issues (1)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM Use_Of_Hardcoded_Password /src/Core/Constants.cs: 169

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

โœ… All modified and coverable lines are covered by tests.
โœ… Project coverage is 55.06%. Comparing base (f2aa742) to head (4e4c4a1).
โš ๏ธ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6816      +/-   ##
==========================================
+ Coverage   55.03%   55.06%   +0.03%     
==========================================
  Files        1934     1934              
  Lines       85581    85777     +196     
  Branches     7656     7675      +19     
==========================================
+ Hits        47098    47236     +138     
- Misses      36695    36750      +55     
- Partials     1788     1791       +3     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • โ„๏ธ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • ๐Ÿ“ฆ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants